[ImageCopy] fix image copy failure when resource group location and disk location differ#2284
Merged
arrownj merged 1 commit intoAzure:masterfrom Sep 3, 2020
arrownj:image_copy_fix
Merged
[ImageCopy] fix image copy failure when resource group location and disk location differ#2284arrownj merged 1 commit intoAzure:masterfrom arrownj:image_copy_fix
arrownj merged 1 commit intoAzure:masterfrom
arrownj:image_copy_fix
Conversation
…isk location differ
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Member
|
Have asked raman from storage to confirm this behavior |
Member
|
Maybe you need to add a test to approve that it solves the issue. |
qwordy
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
create_snapshotfunction, there is a lineHowever service will use this location to retrieve the disk information. If the disk location differs with resource group location, service will throw "Resource disk_xxxxxxxx not found" error.
This makes the
az image copycommand fails.This is a workaround solution from
image-copyside for this case. Thesnapshotissue az image copy failed create snapshot is recorded in azure-cli repo.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.